Conversation
github-actions
bot
added
FY25 Sprint 26
|
@g-saracca I mentioned that Svetlana Lebedeva had some feedback the other day that made me think of dataset templates. Please see https://dataverse.zulipchat.com/#narrow/channel/375707-community/topic/biological.20sample.20level.20information/near/537530702 |
g-saracca
changed the title
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Looks good overall! Could you add a unit test and a test case if return error result
src/datasets/infra/repositories/transformers/DatasetTemplatePayload.ts
Outdated
Show resolved
Hide resolved
| datasetFields: DatasetFieldsPayload | ||
| instructions: Instruction[] | ||
| // 👇 From Edit Template Terms | ||
| termsOfUseAndAccess: { |
There was a problem hiding this comment.
Do you think we may need a separate interface for TermsOfUseAndAccess, based on dataverse TermsOfUseAndAccess? We could make changes on this part until we implement the use case of edit terms
There was a problem hiding this comment.
Same here as comment above, this is the payload, after the mapping I'm using the already there TermsOfUse model.
|
Sorry Cheng, moving to On Hold, until knowing how to proceed based on possible backend/API changes needed. |
|
Moving from On Hold to In Progress, waiting on IQSS/dataverse#11801 |
g-saracca
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
|
@ChengShi-1 this can be reviewed again and also I standardized the License models stuff... |
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Looks good! Thanks for standardizing the license 💯
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
|
Since we're working on templates, I thought I'd mention this interesting feature request (for the future): |
|
tests passing - merging |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
4 participants
What this PR does / why we need it:
Adds the Get Dataset Templates use case.
I've left some useful comments in the models so everyone can understand better the models while we develop the full functionality of dataset templates.
This use case is going to be used in the SPA Create Dataset page.
We can improve and extend tests in future iterations of Dataset Templates, for now I keep them simple.
Which issue(s) this PR closes: